Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns ......................................................................
Patch Set 1: (7 comments) Posted differences between this and master:kudu-1893. http://gerrit.cloudera.org:8080/#/c/6225/1//COMMIT_MSG Commit Message: PS1, Line 24: : * Null default, Range : * Non-null default, Range+IsNotNull : * Non-null default, Range with Default : * Non-null default, Range without Default Removed IsNull test cases http://gerrit.cloudera.org:8080/#/c/6225/1/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: PS1, Line 515: ) Removed "&& !ctx->EvaluatingIsNull()", as IsNull is not in 1.2.x http://gerrit.cloudera.org:8080/#/c/6225/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: PS1, Line 46: namespace tablet { : template<typename KeyTypeWrapper> struct SliceTypeRowOps; : template<typename KeyTypeWrapper> struct NumTypeRowOps; : } // namespace tablet This was added in master:kudu-1880, which is not being included in 1.2.x. Line 486: template<typename KeyTypeWrapper> friend struct tablet::SliceTypeRowOps; Same here. http://gerrit.cloudera.org:8080/#/c/6225/1/src/kudu/tablet/CMakeLists.txt File src/kudu/tablet/CMakeLists.txt: Line 99: ADD_KUDU_TEST(all_types-scan-correctness-test) This was added in master:kudu-1880, which is not being included in 1.2.x. http://gerrit.cloudera.org:8080/#/c/6225/1/src/kudu/tablet/all_types-scan-correctness-test.cc File src/kudu/tablet/all_types-scan-correctness-test.cc: Line 345: int count = 0; Removed Null default, Range+IsNull case. Line 395: AddColumn(read_default); Removed Non-null default, Range+IsNull case. -- To view, visit http://gerrit.cloudera.org:8080/6225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.2.x Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
