Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#5). Change subject: [catalog_manager] proper handling of catalog shutdown ...................................................................... [catalog_manager] proper handling of catalog shutdown This changelist introduces the categorization of the system catalog's read/write operation failures happened while executing the leader post-election task. There are two categories of errors: fatal and non-fatal. If a read/write operation fails in between terms of the system catalog leadership, the error is considered non-fatal. In case of a non-fatal error the leader post-election task bails out: the catalog is no longer the leader at the original term and the task should be executed by the new leader upon the ElectedAsLeaderCb. If a read/write operation fails happened at the same term of the system catalog leadership, the error is considered fatal: this causes the master process to crash. This is done do avoid any possible inconsistency when reading and persisting important system information such as tables/tablets metadata, IPKI certificate authority information and TSKs (Token Signing Keys). All read/write operation failures happened during the system catalog's shutdown are ignored. Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master-test.cc M src/kudu/master/sys_catalog-test.cc M src/kudu/master/sys_catalog.cc 5 files changed, 187 insertions(+), 120 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/6170/5 -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>