Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1906. Fix lost callback for scanner path ......................................................................
KUDU-1906. Fix lost callback for scanner path Fixes another case similar to KUDU-1888 in which we were sending an RPC before setting its deferred. In the case that the RPC responded very quickly, the response would come before the callback was attached, and the callback would never get called. This caused my RowCounter jobs on a small/underpowered test cluster to have task timeouts a few percent of the time. This patch fixes the particular instance and also adds some assertions to try to prevent this style of bug in the future. Change-Id: I102778e87d0f153cdd2a1ca2aed3ec1e17014d4b Reviewed-on: http://gerrit.cloudera.org:8080/6239 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java 4 files changed, 10 insertions(+), 2 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I102778e87d0f153cdd2a1ca2aed3ec1e17014d4b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins
