Dan Burkert has posted comments on this change. Change subject: [security] introduced TokenSigner::HasValidKey() method ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: Line 164: return (tsk_deque_.front()->expire_time() > WallTime_Now()); I'm a little surprised to see this implementation based on the method name. 'HasValidKey' implies to me it will return yes if it has a valid signing key. But this is checking that specifically the first key is valid. Perhaps this should be call 'ShouldRotate' or similar? -- To view, visit http://gerrit.cloudera.org:8080/6246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
