Alexey Serbin has posted comments on this change. Change subject: [util] fixed env_util-test.cc compilation on OS X ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6282/1/src/kudu/util/env_util-test.cc File src/kudu/util/env_util-test.cc: PS1, Line 71: std::max(int64_t(0) > I think the usual way to do this is std::max<int64_t>(0, ...) Yep, that would be better. Just tried to have it closer to the original version :) -- To view, visit http://gerrit.cloudera.org:8080/6282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
