Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6324
to review the following change.
Change subject: [sys_catalog] no copying into intermediate KuduPartialRow
......................................................................
[sys_catalog] no copying into intermediate KuduPartialRow
Use KuduPartialRow::SetStringNoCopy() instead of
KuduPartialRow::SetString() while setting fields for the system catalog
table. Copying the data into the intermediate KuduPartialRow object is
not necessary: the intermediate object is not used once the data is
encoded into the result WriteRequestPB via RowOperationsPBEncoder.
Change-Id: I0dbcb822d8f85e1101846409e90e2e5af0afc4f3
Reviewed-on: http://gerrit.cloudera.org:8080/6315
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: David Ribeiro Alves <[email protected]>
(cherry picked from commit 5a24fe6742611c71fe272b37a1fd6afcc089c998)
---
M src/kudu/master/sys_catalog.cc
1 file changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/6324/1
--
To view, visit http://gerrit.cloudera.org:8080/6324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dbcb822d8f85e1101846409e90e2e5af0afc4f3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
