Alexey Serbin has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6340/4/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: PS4, Line 61: explicit nit: consider dropping 'explicit' -- it seems we don't bother about initializer-list assignments. Line 217: RpcEncryption encryption_; Consider adding 'const' specifier. http://gerrit.cloudera.org:8080/#/c/6340/4/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS4, Line 388: encryption_ != RpcEncryption::DISABLED && nit for here and elsewhere: I'm not sure whether compiler is capable of optimizing this on its own, but I would put the 'static' condition first, like if (encryption_ != RpcEncryption::DISABLED && ...) { ... } because other criteria like ContainsKey() look more CPU consuming. http://gerrit.cloudera.org:8080/#/c/6340/4/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: PS4, Line 58: explicit nit: consider dropping explicit since we don't bother with list-lie initializers, e.g. ServerNegotiation sn = { s, tls, verfier, enc }; Line 219: RpcEncryption encryption_; Consider adding const modifier -- it seems this member is not modified once the object is constructed. -- To view, visit http://gerrit.cloudera.org:8080/6340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf17c6bb59ca4af1215376c5221a90bd1d93b64 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
