David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 8: Code-Review+1 (2 comments) left a couple of comments. like the approach better, thanks for the improvements. letting mike take it the rest of the way. http://gerrit.cloudera.org:8080/#/c/6066/8/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS8, Line 1612: // Take the snapshot of the queue state and timestamp to stick them : // in the consensus request later. : int64_t all_replicated_index = queue_->GetAllReplicatedIndex(); : int64 last_committed_index = queue_->GetCommittedIndex(); : OpId preceding_opid = queue_->GetLastOpIdInLog(); : uint64 msg_timestamp = time_manager_->GetSafeTime().value(); needs to be done under the lock. PS8, Line 1672: LOG_WITH_PREFIX(WARNING) : << "REPLACING THE CONFIG ON THIS SERVER WITH A NEW CONFIG," : << "THIS OPERATION IS IRREVERSIBLE !!\n" : << "COMMITTED CONFIG :" << committed_config.DebugString() : << "NEW CONFIG :" << new_config.DebugString(); add one like this with the result of the actual change config. -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
