David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1843. Client UUIDs should be cryptographically random ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6347/1/src/kudu/security/crypto-test.cc File src/kudu/security/crypto-test.cc: PS1, Line 257: for (int i = 0; i < 5; i++) { nit: would running this for 100 iters or something increase meaningfully chances of collision? -- To view, visit http://gerrit.cloudera.org:8080/6347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ea6868773cf046944f70c32c647184e4b48c772 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
