Hello David Ribeiro Alves, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6376
to review the following change.
Change subject: KUDU-1933. consensus: Fix integer overflow in log index
......................................................................
KUDU-1933. consensus: Fix integer overflow in log index
We observed a crash on a long-running master server that looked like the
following:
F0308 00:25:53.568773 7655 log_index.cc:171] Check failed: log_index > 0
(-2147483648 vs. 0)
It turns out that this was caused due to integer overflow on the log
index field. This patch fixes this type of truncation in a couple of
places (LogReader and MakeOpId()) and adds a couple of new tests that
fail without both of those fixes.
This patch also includes some test helper fixes to avoid log index
integer truncation in future tests.
Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/opid_util.h
M src/kudu/tablet/tablet_bootstrap-test.cc
9 files changed, 61 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6376/1
--
To view, visit http://gerrit.cloudera.org:8080/6376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
