Adar Dembo has posted comments on this change. Change subject: Add InboundCall::GetTransferSize() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6374/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 188: CHECK_LT(0, incoming->GetTransferSize()); This feels somewhat unidiomatic; maybe convert to CHECK_GT(size, 0)? -- To view, visit http://gerrit.cloudera.org:8080/6374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
