Adar Dembo has posted comments on this change.

Change subject: [scanner] LOG(INFO) --> VLOG(1) on scanner expiration
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6416/1/src/kudu/tserver/scanners.cc
File src/kudu/tserver/scanners.cc:

Line 169:       VLOG(1) << "Expiring scanner id: " << it->first << ", of tablet 
" << scanner->tablet_id()
Nit: since you're already modifying this, mind using strings::Substitute()? 
Makes it easier to visualize the entirety of complex strings like this one.


-- 
To view, visit http://gerrit.cloudera.org:8080/6416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78f0b07131aaf4dc4a2cb72bed1ce1647a201b68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to