Mike Percy has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6422/3/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 471: // This will cause any pending TabletMetadata flush to be executed, if any. > Nit: redundant "any" between "any pending" and "if any". Done Line 472: Status unpin_status = meta_->UnPinFlush(); > Is it possible for this to flush even if !bootstrap_status.ok()? That seems Yes, it will always flush is there were tablet updates. This is an interesting question and I wonder what David thinks about this. Because we always roll forward on tablet bootstrap, I don't think it's necessarily bad to do that. In fact, it's probably good because it avoid orphaning blocks? -- To view, visit http://gerrit.cloudera.org:8080/6422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
