Adar Dembo has posted comments on this change. Change subject: cfile_set: reduce memory usage of reader map ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6466/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: Line 103: gscoped_ptr<CFileReader> reader; Can you convert to unique_ptr in the affected call sites? Or does that spill out all over the place? http://gerrit.cloudera.org:8080/#/c/6466/1/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: Line 121: // Map of column ID to reader. These are lazily initialized as needed. May want to leave a comment justifying flat_map, since it's somewhat unorthodox for us. PS1, Line 122: > Nit: eliminate empty space. -- To view, visit http://gerrit.cloudera.org:8080/6466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3812861a11b00e149ca47b090447bc918c465ad4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
