David Ribeiro Alves has posted comments on this change. Change subject: generic_iterators: avoid holding completed iters in merge/union ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6460/1//COMMIT_MSG Commit Message: PS1, Line 16: With the patch, I no longer see this : behavior. what is the behavior? memory consumption is constant? http://gerrit.cloudera.org:8080/#/c/6460/1/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: Line 54: extra line Line 65: nit: mind making the spacing above/below the anonymous namespace consistent? http://gerrit.cloudera.org:8080/#/c/6460/1/src/kudu/common/generic_iterators.h File src/kudu/common/generic_iterators.h: PS1, Line 78: vector<IteratorStats> finished_iter_stats_by_col_; docs PS1, Line 124: void PopFront(); docs PS1, Line 131: vector<IteratorStats> finished_iter_stats_by_col_; docs -- To view, visit http://gerrit.cloudera.org:8080/6460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e068c256c5855efeff5c6325dbb5fbf770eb900 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
