Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas ......................................................................
Patch Set 17: (8 comments) http://gerrit.cloudera.org:8080/#/c/6066/17//COMMIT_MSG Commit Message: PS17, Line 24: fake "fake" PS17, Line 40: UnasfeChangeConfig UnsafeChangeConfig http://gerrit.cloudera.org:8080/#/c/6066/17/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS17, Line 778: . Nit: please also add a space after this period (and all periods) PS17, Line 780: , please add a space after this comma (and all commas) http://gerrit.cloudera.org:8080/#/c/6066/17/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1597: << state_->GetPendingConfigUnlocked().ShortDebugString(); Use SecureShortDebugString() from pb_util.h: << SecureShortDebugString(state_->GetPendingConfigUnlocked()); PS17, Line 1694: committed_config.ShortDebugString() SecureShortDebugString(committed_config) PS17, Line 1695: new_config.ShortDebugString() SecureShortDebugString(new_config) http://gerrit.cloudera.org:8080/#/c/6066/16/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: PS16, Line 366: << "to other peers and it may take a while to bring the tablet " : << "back to majority replica count depending upon how much time " : << "the new peer replicas take to catch up with the tablet server " : << "enforcing the new config."; : > My concern about removing this message is that, user wouldn't know about th It's still there in rev 17. Personally I think if they are using this tool they should know what they're doing and I don't think this warning provides enough context. This kind of info should go into docs. -- To view, visit http://gerrit.cloudera.org:8080/6066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908d8c981df74d56dbd034e72001d379fb314700 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
