Mike Percy has posted comments on this change. Change subject: kudu-mapreduce: tweak poms ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-client and kudu-mapreduce. > kudu-mapreduce only has three compile-scope dependencies: I think it's valuable to shade async and kudu-client because async is exposed as part of the kudu-client public API and the asynchbase client has a dependency on async. Without shading, if you want to write to both HBase (using asynchbase) and Kudu in the same M/R job then you would have to worry about library versioning conflicts otherwise. I don't think it's possible or desirable to shade slf4j; see PARQUET-369 for an example of how that can go badly. -- To view, visit http://gerrit.cloudera.org:8080/6418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I599ea9610fc3d541847b0205e959e94fb8425b2e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
