Adar Dembo has posted comments on this change. Change subject: Move maintenance_manager to server/ ......................................................................
Patch Set 1: Code-Review-1 I'd like to eventually use the MM in the log block manager to clean up full containers with no live blocks. If it was moved into server/, the implementation would have to be much more indirect. For example, instead of just passing a pointer to the MM into the LBM constructor, the LBM would have to expose appropriate MM op methods (like UpdateStats, Prepare, and Perform) and the op itself would be defined and registered elsewhere. It can be done, but it seems more inelegant to me, plus it'd require poking holes in the block manager abstraction. If you want it out of util/, perhaps we can move it to common/? Or, alternatively, we could start a "Kudu-only" util/ and put it there? -- To view, visit http://gerrit.cloudera.org:8080/6506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f89fa0e1ffa7304e29262edfab21b49d8b91665 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
