David Ribeiro Alves has posted comments on this change. Change subject: rowset_tree: add bulk queries ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6482/4/src/kudu/tablet/rowset_tree-test.cc File src/kudu/tablet/rowset_tree-test.cc: PS4, Line 108: const int kNumRowSets = 200; can you increase the number of rowsets to maybe make this more realistic? feels like 1M rows in a single batch to a single tablet is over the range we usually see, whereas 200 rowsets is under the range we usually see. http://gerrit.cloudera.org:8080/#/c/6482/4/src/kudu/tablet/rowset_tree.h File src/kudu/tablet/rowset_tree.h: PS4, Line 80: callback callbacks -- To view, visit http://gerrit.cloudera.org:8080/6482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab24681dfbb3b1e6f08d52eb0647a5f3ca6851f Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
