David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] updated client model for Jepsen tests ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6565/1//COMMIT_MSG Commit Message: PS1, Line 10: write and scan : operations. all operations. (that is this also does write-write and scan-scan) http://gerrit.cloudera.org:8080/#/c/6565/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj: PS1, Line 40: state-atom why state-atom and not "client-atom"? PS1, Line 45: newclient (kc/sync-client (:master-addresses test)) you're always creating a new client even if you don't need it. could you just use the atom instead? PS1, Line 47: compare-and-set! state-atom nil newclient I mean doing: (compare-and-set! state-atom nil (kc/sync-client (:master-addresses test))) here and then using the atom below -- To view, visit http://gerrit.cloudera.org:8080/6565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If67328230cc821129babcb5fa40fcbbb503eea39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
