Alexey Serbin has posted comments on this change.

Change subject: [kudu-jepsen] install Kudu packages into local repo
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6256/1/src/kudu/scripts/jepsen.sh
File src/kudu/scripts/jepsen.sh:

PS1, Line 126: mvn $MVN_FLAGS -Pjepsen clean compile test-compile
             : 
             : echo
             : echo "Installing Kudu Java packages into local mvn repository"
             : echo ------------------------------------------------------------
             : mvn $MVN_FLAGS -DskipTests install
> why not do the install in the first mvn call?
I thought it's worth separating build and install targets.  To me it does not 
seem natural to mix those.

But since it seems it would re-do the dependent targets again, it makes more 
sense to put them into one line.

Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/6256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I056fb9c5791fbd4850df7a87d8d6f3014ec3284f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to