Alexey Serbin has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden); > You sure the intent was to make this flag hidden and not consensus_rpc_time As I understand, consensus_rpc_timeout_ms is already hidden by corresponding TAG_FLAG() macro at line 50. That's why I think it's a typo. But it would be nice if David or Todd could confirm that, sure. -- To view, visit http://gerrit.cloudera.org:8080/6580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
