Adar Dembo has posted comments on this change. Change subject: log block manager: corruptor test utility ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6582/1/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: Line 338: } else if (r == 1) { > warning: don't use else after return [readability-else-after-return] Done Line 372: if (full_containers_.size() == 0) { > warning: the 'empty' method should be used to check for emptiness instead o Done Line 380: if (all_containers_.size() == 0) { > warning: the 'empty' method should be used to check for emptiness instead o Done -- To view, visit http://gerrit.cloudera.org:8080/6582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197b693d5a3c1a909e91b772ebfb31e50bae488b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
