David Ribeiro Alves has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS1, Line 908: } : } : if (found_offset == 0) { : LOG(INFO) << "Couldn't find extent to split, skipping this part of the test"; : return; : } : : // Punch out a hole and split the extent. : s = f->PunchHole(found_offset, fs_block_size); : if (s.IsNotSupported()) { : > It's virtually impossible. One of the following would have to be true (assu If it's virtually impossible can we just fail and adjust later if we find a case where it's not? Just want to make sure that we're forced to deal with it in case our assumption is wrong. http://gerrit.cloudera.org:8080/#/c/6583/3/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: Line 888: LOG(INFO) << "Extent layout before hole punch"; nit, end sentence with colon http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env.h File src/kudu/util/env.h: PS1, Line 589: // platform doesn't support fetching extents at > I'm not actually sure that it's the best approach for C++11. I think we sho yeah, typedefs are quite traditional by now. fwiw I meat the location of the typedeffing http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS1, Line 732: TRACE_EVENT1("io", "PosixRWFile::GetExtentMap", "path", filename_); > It's traceable because I believe the convention for all env_posix.cc functi right, but for things that are done "online" no? isn't this supposed to always run offline? when would you observe the trace? -- To view, visit http://gerrit.cloudera.org:8080/6583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35bd1bdb9e1a839af2ab95ea73b79217c1f4a2b3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
