Dan Burkert has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC ......................................................................
Patch Set 2: (1 comment) Could you add some test coverage of this to negotiation-test.cc? I think the easiest thing to do is to add a variant to the PkiConfig enum to indicate externally signed cert, and then make a test case with that. http://gerrit.cloudera.org:8080/#/c/6594/2/docs/design-docs/rpc.md File docs/design-docs/rpc.md: Line 488: | Does the server have | yes | Does the client have | | | Instead of adding the additional state, would it be correct to change 'Does the client have a CA-signed TLS certificate?' state to 'Does the client have an internal-CA-signed TLS certificate?'? -- To view, visit http://gerrit.cloudera.org:8080/6594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd44770a1fe85e9934a657ee79d93139b9a86dff Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
