Dan Burkert has posted comments on this change. Change subject: [client-test] fix flakes of flush mode timing tests ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6607/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 2510: enum RowSizeMode { It's up to personal style, but I like having enums like this be an enum class, and removing the enum name from the variants: enum class RowSize { CONSTANT, RANDOM, } Then they can be referred to as RowSize::CONSTANT, etc. Line 2541: // Run the scenario multiple times to factor out fluctuations of multi-tasking This is just taking the sum of the times across the 16 runs. Just spitballing, but could we get more stable results by doing a simple statistical test, since we now have multiple samples? Perhaps comparing medians? Maybe something to think about if this remains flaky. -- To view, visit http://gerrit.cloudera.org:8080/6607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee2abc59785b83fe116a542a265a61281b2f9741 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
