Adar Dembo has posted comments on this change. Change subject: pstack_watcher: set a limit on backtrace depth ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6658/1//COMMIT_MSG Commit Message: PS1, Line 14: apparently the spinning is due to gdb getting in some infinite loop : trying to walk the stack with insufficient/incorrect debug info. Do we have a reference for this part though? I didn't see that conclusion reached in the linked bug report or any of its related bugs. http://gerrit.cloudera.org:8080/#/c/6658/1/src/kudu/util/pstack_watcher.cc File src/kudu/util/pstack_watcher.cc: Line 139: argv.push_back("set backtrace limit 100"); Could you add a comment explaining why we do this? I think the rest of the commands are self-explanatory, but feel free to also comment any that you think may not be. -- To view, visit http://gerrit.cloudera.org:8080/6658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide46209256fd4ced6b08065c2ae3c0046de49565 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
