Alexey Serbin has submitted this change and it was merged.
Change subject: [rpc] close socket on AcceptorPool::Shutdown()
......................................................................
[rpc] close socket on AcceptorPool::Shutdown()
Close the underlying socket upon AcceptorPool::Shutdown() call. It does
not make much sense keeping the socket open after calling shutdown()
for both send and receive.
Due to the typical ownership pattern of AcceptorPool two references to
the object is kept: one reference is kept by RpcService, another by
Messenger. So, to close the socket it's necessary to call both
{RpcService,Messenger}::Shutdown() methods.
This patch also fixes delete_tablet-itest on MacOS X.
Change-Id: Ided3643b07e642beb586e51efa442b39b3785916
Reviewed-on: http://gerrit.cloudera.org:8080/6665
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <[email protected]>
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/messenger.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/util/net/socket.cc
6 files changed, 31 insertions(+), 26 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ided3643b07e642beb586e51efa442b39b3785916
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
