Alexey Serbin has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: PS2, Line 174: string Mode::BuildHelpXML(const vector<Mode*>& chain) const { : string xml; : xml += "<mode>"; : xml += Substitute("<name>$0</name>", name()); : xml += Substitute("<description>$0</description>", : EscapeForHtmlToString(description())); : for (const auto& a : actions()) { : xml += a->BuildHelpXML(chain); : } : : for (const auto& m : modes()) { : vector<Mode*> m_chain(chain); : m_chain.push_back(m.get()); : xml += m->BuildHelpXML(m_chain); : } : xml += "</mode>"; : return xml; Is it possible to use libxo library https://github.com/Juniper/libxo for that instead of building that manually? Doing so would automatically add support for JSON and HTML output. -- To view, visit http://gerrit.cloudera.org:8080/6645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
