Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6691
to review the following change.
Change subject: rowset_tree-test: protect against divide by zero
......................................................................
rowset_tree-test: protect against divide by zero
A precommit run failed in ASAN with the following error:
[----------] 20 tests from Parameters/TestRowSetTreePerformance
[ RUN ] Parameters/TestRowSetTreePerformance.TestPerformance/0
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0419 02:42:55.175978 12769 test_util.cc:180] Using random seed: -79660807
I0419 02:42:55.403628 12769 rowset_tree-test.cc:176] Q= 10 R= 10
1-by-1 36 ms
/home/jenkins-slave/workspace/kudu-master/3/src/kudu/tablet/rowset_tree-test.cc:184:39:
runtime error: division by zero
SUMMARY: AddressSanitizer: undefined-behavior
/home/jenkins-slave/workspace/kudu-master/3/src/kudu/tablet/rowset_tree-test.cc:184:39
in
It seems incredibly unlikely for batch_total to be 0, but on my laptop I
was able to reproduce this reliably in the first iteration (where the number
of queries and rowsets are 10).
Change-Id: I7033f3242924eabc5e843546bb879a16559a6aed
---
M src/kudu/tablet/rowset_tree-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/6691/1
--
To view, visit http://gerrit.cloudera.org:8080/6691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7033f3242924eabc5e843546bb879a16559a6aed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
