Hao Hao has posted comments on this change. Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/6566/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: Line 474: private final Callback<RowResultIterator, Response> gotNextRow = > Changed it because nextRowErrback is returning Deferred obj, so to be consi Done Line 506: if (e instanceof ScannerExpiredException) { > My understanding of how Java client error handling works for tablet server Done Line 511: return Deferred.fromError(e); // Let the error propagate. > 'propagate' was more correct. Done Line 835: return new Pair<Response, Object>(null, error); > Is this case being handled? Done -- To view, visit http://gerrit.cloudera.org:8080/6566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d3634c4255b69e28f2de5412e6a5a9d34e931b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
