Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6704/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: Line 365: resp->mutable_error()->mutable_status()->set_code(AppStatusPB::UNKNOWN_ERROR); Doesn't this overwrite the work of StatusToPB()? Line 370: resp->mutable_deprecated_error()->set_code(AppStatusPB::UNKNOWN_ERROR); This too? -- To view, visit http://gerrit.cloudera.org:8080/6704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e175df2cecad4f62806bc3ea0c314e5b861e40 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
