Adar Dembo has posted comments on this change. Change subject: log block manager: corruptor test utility ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6582/7/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: PS7, Line 26: <gflags/gflags.h> > nit: it seems <glags/gflags_declare.h> wound be enough in this case. Done PS7, Line 322: for (auto iter = all_containers_.begin(); iter != all_containers_.end();) { : if (iter->name == c->name) { : all_containers_.erase(iter); : break; : } else { : iter++; : } : } > nit: would something like Done -- To view, visit http://gerrit.cloudera.org:8080/6582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197b693d5a3c1a909e91b772ebfb31e50bae488b Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
