Pavel Martynov has posted comments on this change. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added. ......................................................................
Patch Set 1: (1 comment) Reply on TestServerInfo.java comments http://gerrit.cloudera.org:8080/#/c/6735/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java: Line 12: @Test(timeout = 500) > was it previously so slow that this timeout would fire? Yes, without my patch this test runs about 5 seconds on my desktop. Also, I checked NetworkInterface.getNetworkInterfaces() on my Windows desktop and laptop, it returns 35 and 41 respectively (most of them - some virtual interfaces, not manageable by a user). Slow DNS respond is not a problem, because it simply not performed: "If a literal IP address is supplied, only the validity of the address format is checked." (see http://docs.oracle.com/javase/7/docs/api/java/net/InetAddress.html#getByName%28java.lang.String%29). Yes, I already verified on my initial insert-loadgen sample program and insert pace increased by 15-20 times. Well, I am also not a big fan of such tests, so I understand you correctly that is better to remove it completely? -- To view, visit http://gerrit.cloudera.org:8080/6735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc9d40ebffa17ef43973dc23237dd31dd309c06 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Pavel Martynov <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Pavel Martynov <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
