David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6715/3/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: PS3, Line 295: uint64_t block_length = rand_.Uniform(fs_block_size * 4); : block_length -= block_length % block_id_str_len; : uint8_t data[block_length]; : for (int i = 0; i < ARRAYSIZE(data); i += block_id_str_len) { : memcpy(&data[i], block_id_str.data(), block_id_str_len); : } it's ok if this writes a 0 sized block, right? http://gerrit.cloudera.org:8080/#/c/6715/3/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: PS3, Line 782: Need to reopen the block manager after each corruption. why? -- To view, visit http://gerrit.cloudera.org:8080/6715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ed6e349ab10d8d04722cd7ef99e7a06554f51f1 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
