Adar Dembo has posted comments on this change. Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6755/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 116: DEFINE_string(redact, "all", Dan, David, myself, and Hao talked about this in person, and I wanted to summarize the discussion for the benefit of others. I raised the concern that with the addition of 'flag' --redact seems to be controlling two separate axes: context (i.e. "Should I redact in the web UI? Should I redact while logging?") and data type (i.e. "Should I redact sensitive gflag values? Should I redact user data?"). I found this comingling to be confusing and suggested that we either: 1. Split this gflag into two, one for controlling redaction context and the other for redaction data types. 2. Choose a hardcoded policy for one of the two axes and restrict --redact to controlling the other axis. In our discussion, we reached a rough consensus that redaction context is far more interesting than redaction data types. Thus, we think option #2 is preferable, and that redaction data types should always be "all" while redaction context should be controllable. As far as what this means for this patch, Hao will: 1. Retain the addition of 'web'. 2. Remove the 'flag' option. 3. Wherever 'flag' was used to decide whether to redact sensitive gflag values, instead consider just the context (are we logging? am I in the web UI? etc). -- To view, visit http://gerrit.cloudera.org:8080/6755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32fe0c4e65f22d6f9f3d188018b119f07300e26f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
