Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6758/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 260: *result = Slice(scratch, 0); > A calling convention we like to adhere to is: if the function returns a bad Done Line 270: Substitute("Can't short read great than or equal to the $0 bytes requested", length)); > Since this is test-only, perhaps just CHECK fail here? Done Line 288: *result = Slice(scratch, result->size() + r); > Given the above calling convention, you should only need to set up the resu Done -- To view, visit http://gerrit.cloudera.org:8080/6758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
