Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6758
to look at the new patch set (#6).
Change subject: env: Always read fully when reading files
......................................................................
env: Always read fully when reading files
In KUDU-9 env_util::ReadFully was added to ensure
short reads were retried until all data was read.
Later RWFile was implemented with “read fully” behavior by default.
(see a15c795360e32885c00442efacd2a345f993f425)
Given we almost always use ReadFully or expect the data to be
fully read regardless, this patch moves the “read fully” behavior
into the Read function so it is always used.
Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69
---
M src/kudu/consensus/log_util.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
13 files changed, 78 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/6758/6
--
To view, visit http://gerrit.cloudera.org:8080/6758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
