Adar Dembo has submitted this change and it was merged. Change subject: external mini cluster: spawn perf record for each daemon during Start() ......................................................................
external mini cluster: spawn perf record for each daemon during Start() I want this for the dense node test, but it's not really possible to do from outside ExternalMiniCluster without missing out on time spent in Start(), which I was interested in measuring. So here's a generic approach that can be used by any itest. I wasn't sure whether this should be configured via EMC option or gflag. I ended up with the latter because it's not really something a test needs programmatic access to; it's just something the dev running the test might want to enable manually. I also changed the existing perf calls in full_stack-insert-scan-test to use the new subprocess custom destroy signal. While there I fixed the handling of "--call-graph"; passing it without "fp" is a syntax error on both el6.6 and Ubuntu 16.04. Change-Id: I92079f616648788b461d550057b8e23bc9174b71 Reviewed-on: http://gerrit.cloudera.org:8080/6742 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/integration-tests/full_stack-insert-scan-test.cc 3 files changed, 61 insertions(+), 32 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92079f616648788b461d550057b8e23bc9174b71 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
