William Li has posted comments on this change. Change subject: [KUDU-754] add an environment variable for kudu client debugging to stderr ......................................................................
Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/6736/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: PS2, Line 259: e > nit: please add period (.) in the end of the sentence. Done PS2, Line 260: Verbos > nit: probably, it's worth dropping the 'Client' part since it's already in Done Line 262: > ditto Done PS2, Line 263: t > nit: if it's already in the 'client' namespace, may be it's possible to dro Done http://gerrit.cloudera.org:8080/#/c/6736/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 5057: // Test the client retries on ServiceUnavailable errors. This scenario uses > Does it make sense to add a case for negative and non-parsable values to ve Done http://gerrit.cloudera.org:8080/#/c/6736/2/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 21: #include <cstdlib> > nit: please add #include <cstdlib> since std::getenv() is from that header Done PS2, Line 151: evel > nit: nullptr Done PS2, Line 155: > nit: does it make sense to output the name of the variable? Done http://gerrit.cloudera.org:8080/#/c/6736/3/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 25: #include <unordered_map> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/6736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5c7c24395c25184489200283dd38da024c07bb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: William Li <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: William Li <[email protected]> Gerrit-HasComments: Yes
