Alexey Serbin has posted comments on this change.

Change subject: [webui] Fix master reg formatting and add memory use percentage.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6780/3/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:

PS3, Line 160:   *output << Substitute("  <tr><th>Percentage 
consumed</th><td>$0%</td></tr>\n",
             :                         StringPrintf("%.2f", percentage));
nit: is it worth putting this under if (hard_limit > 0) clause?


-- 
To view, visit http://gerrit.cloudera.org:8080/6780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe1f11b153f16753f94c3dae67cce97679e46dbc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to