Hao Hao has posted comments on this change. Change subject: [java client] improve flaky test ITClient ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6776/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS2, Line 729: shutdownConnection > nit: shutdownConnection Done http://gerrit.cloudera.org:8080/#/c/6776/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 147: /** > It's minor, but I'd rather not add a new constructor if we're just using it Done http://gerrit.cloudera.org:8080/#/c/6776/2/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: Line 417: .setFaultTolerant(true); > Yeah like this https://github.com/apache/kudu#running-tests-with-the-clang- I ran the test with ASAN enabled for a dozen of time. And it seems working fine. -- To view, visit http://gerrit.cloudera.org:8080/6776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81946e951db69d6c75c6a2e22a802cc4f4c447b9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
