Jean-Daniel Cryans has posted comments on this change. Change subject: mapreduce: add support for fault tolerant scanner ......................................................................
Patch Set 5: (2 comments) some nits and then we're good to go http://gerrit.cloudera.org:8080/#/c/6745/5/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java: Line 91: /** Job parameter that specifies if the scanner should be fault tolerant nit: if you do multi-line, start writing on the second line. http://gerrit.cloudera.org:8080/#/c/6745/5/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java: PS5, Line 216: . nit: no period here -- To view, visit http://gerrit.cloudera.org:8080/6745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc39472e2733bab4e00e73658f8a7619153bd7c6 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
