David Ribeiro Alves has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
......................................................................


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/6774/3/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS3, Line 105: The happiness is when Jepsen's analysis finds the history of 
operations
             : consistent for each test. If that happens, the following is 
output in the end
             : of a test:
this reads weird. how about:
When Jepsen's analysis doesn't find inconsistencies in the history of 
operations it outputs the following in the end of a test:


PS3, Line 113: why Jepsen
             : was not happy about the run.
replace with: why the test failed.


PS3, Line 120: other
             :   errors reported by
replace with: or in any of the


PS3, Line 125:  or
nit: replace this "or" with a comma


PS3, Line 129: issues like that
replace with: "errors in 10 tests ran"


PS3, Line 139: manifestations
"a manifestation"


PS3, Line 140: These are
This is...


PS3, Line 141: on 
remove


PS3, Line 149: it outputs something like the following
             : into the log:
nit: it would be good to keep the first sentence consistent with this one.


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to