Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6795
to look at the new patch set (#3).
Change subject: [util] introduced custom gflags validators
......................................................................
[util] introduced custom gflags validators
Use CUSTOM_FLAG_VALIDATOR() macro to register late-phase validator
function for flags. The validation is performed upon call of
HandleCommonFlags() invoked by the top-level ParseCommandLineFlags()
function.
Added unit test to cover the new functionality.
Updated validators for security-related RPC and embedded webserver
flags.
This patch addresses the following JIRA item:
KUDU-1993: The validation of 'grouped' flags works incorrectly
if flags re-ordered
Change-Id: I3755d62590cdc63a9d501ba69d980cb15f8069a9
---
M src/kudu/rpc/messenger.cc
M src/kudu/server/webserver_options.cc
M src/kudu/util/CMakeLists.txt
A src/kudu/util/flag_validators-test.cc
A src/kudu/util/flag_validators.cc
A src/kudu/util/flag_validators.h
M src/kudu/util/flags.cc
M src/kudu/util/test_main.cc
8 files changed, 353 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/6795/3
--
To view, visit http://gerrit.cloudera.org:8080/6795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3755d62590cdc63a9d501ba69d980cb15f8069a9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
