David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1970: node density integration test ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6662/9/src/kudu/integration-tests/dense_node-itest.cc File src/kudu/integration-tests/dense_node-itest.cc: PS9, Line 71: DenseNodeTest > I don't think a new convention is necessary, and FWIW I see enough overlap right, hence the "most". the point is: do you agree that it would be nice to stress only or bench only tests have a bench suffix or not? fwiw IMO it would be handy to be able to easily identify the binaries for benchmarks among the others when looking for ways to measure something. if not I'm ok with that too, just don't want to avoid making things better because there is no precedent. -- To view, visit http://gerrit.cloudera.org:8080/6662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9b5d01557eb41d386ce92f576ed01ec658e8e7d Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
