Hao Hao has posted comments on this change. Change subject: WIP KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6514/11/src/kudu/rpc/negotiation-test.cc File src/kudu/rpc/negotiation-test.cc: PS11, Line 155: tring("192. > This looks like an IP network address, not a single IP. Also, why not to j Done PS11, Line 222: unique_ptr<Socket>(new Socket()); : > nit: why not to do that at the point of declaration of server_socket? Done http://gerrit.cloudera.org:8080/#/c/6514/11/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: PS11, Line 208: const So > Is this signature intended for the move semantics? Right, will change it. Thanks for pointing out. -- To view, visit http://gerrit.cloudera.org:8080/6514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c3fbb5491785874c5701d6c9d866949cfac905e Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Harsh J <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
