David Ribeiro Alves has posted comments on this change. Change subject: cache: add a benchmark ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench.cc: Line 95: nit: extra line PS1, Line 97: TEST_P(CacheBench, RunBench) { would it be interesting to also measure cache churn? PS1, Line 98: 16; make this a flag? -- To view, visit http://gerrit.cloudera.org:8080/6696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I156d170c20913a17e4f94b40879409f4798023ab Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
