Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile ......................................................................
Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/6630/14/docs/design-docs/cfile.md File docs/design-docs/cfile.md: Line 27: Header > Can you update this to reflect that the checksums are optional (and maybe d I will add that they are optional. I am not sure if the cflags should go in this document since it describes the format and not the details of the reader/writer implementations. http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: Line 847: Status s = CorruptAndReadBlock(id, i, 254); > I had something similar to this at one point but I worried I was getting to Done http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 438: } > I understand, but what exactly does it mean for a ReadBlock() call to provi Since this is a public method I want to validate the input parameters. I don't think there is ever a valid scenario where a block would ever have 3 bytes or less. However, when hasChecksums is true, this is always the case given the checksum is 4 bytes and is included in the size. -- To view, visit http://gerrit.cloudera.org:8080/6630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6756834cd7f27af258797a3654a95244abeb0976 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
