Adar Dembo has posted comments on this change. Change subject: [java-client] update protoc maven plugin ......................................................................
Patch Set 2: It appears I'm late to the party, but I have two requests: 1. Looks like this newer version of protobuf-maven-plugin defines a property (https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html#attachProtoSources) that can obviate the need for delete-test-protos (see java-client/pom.xml); can you look into this? 2. More importantly, beginning with 2.6.1 protoc is available as a maven artifact itself (https://www.xolstice.org/protobuf-maven-plugin/faq.html#faq_1). If we consumed it as such, it has the potential to drastically simplify our Java build: - We could remove all of the maven profiles associated with finding the right version of protoc. - We could rev protobuf in thirdparty (for the server and C++ client) independently of the protobuf/protoc maven artifacts (for the Java client). Could you investigate this? -- To view, visit http://gerrit.cloudera.org:8080/6830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
